Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webapp example #2352

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Add webapp example #2352

merged 4 commits into from
Aug 14, 2024

Conversation

nypava
Copy link
Contributor

@nypava nypava commented Jul 27, 2024

Description

Simple webapp example

@coder2020official
Copy link
Collaborator

That's too simple...

@nypava
Copy link
Contributor Author

nypava commented Jul 27, 2024

IG it is pretty enough as an example.

@Badiboy
Copy link
Collaborator

Badiboy commented Jul 27, 2024

IG it is pretty enough as an example

If library mainteinter says that something is wrong it's better to take it into account.

@coder2020official
Copy link
Collaborator

@Badiboy did you turn off notifications for my states PR or are you in process of review? I got no comment saying it is in the review, so I hope you have seen it

@nypava
Copy link
Contributor Author

nypava commented Jul 27, 2024

IG it is pretty enough as an example

If library mainteinter says that something is wrong it's better to take it into account.

I wasn't being stubborn. I was simply stating my opinion on why it is simple, so that he could further explain his point.

@coder2020official
Copy link
Collaborator

coder2020official commented Jul 27, 2024

Maybe you could improve your example in some ways; Use @asmico_attach_bot as an example, try to expand the functionality to show some basic yet useful things in webapp

@nypava
Copy link
Contributor Author

nypava commented Jul 27, 2024

Sure, I will add some features. My intention was to show how to implement a webapp using pytelegrambotapi, rather than to showcase the functionality of webapp it self.

@coder2020official
Copy link
Collaborator

Well, anyone can implement a mini app using code, and simply changing link to google.com
Still a mini app :)

@nypava
Copy link
Contributor Author

nypava commented Aug 4, 2024

@coder2020official what about now?

@coder2020official
Copy link
Collaborator

Thanks, that is a really good example.
A few things before merging:

  • Rename Web App to Mini App(mini_app folder, texts, etc)
  • Create an example for async, write a comment at the top saying sources of website are at examples/mini_app

@nypava
Copy link
Contributor Author

nypava commented Aug 12, 2024

  • Create an example for async, write a comment at the top saying sources of website are at examples/mini_app

As I am going add async support is it fine to use this structure? (rather than duplicating web file twice)

examples/
├─ mini_app_web/
│ ├─ index.html
│ ├─ script.js
│ ├─ style.css
├─ asynchronous_telebot/
│ ├─ mini_app.py
├─ mini_app.py

@coder2020official
Copy link
Collaborator

yep sounds good to me, no need for duplicating
just don't forget to leave comments telling abt this

@coder2020official
Copy link
Collaborator

LGTM. @Badiboy ?

@Badiboy Badiboy merged commit 1bd9cd9 into eternnoir:master Aug 14, 2024
7 checks passed
@Badiboy
Copy link
Collaborator

Badiboy commented Aug 14, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants