-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webapp example #2352
Add webapp example #2352
Conversation
That's too simple... |
IG it is pretty enough as an example. |
If library mainteinter says that something is wrong it's better to take it into account. |
@Badiboy did you turn off notifications for my states PR or are you in process of review? I got no comment saying it is in the review, so I hope you have seen it |
I wasn't being stubborn. I was simply stating my opinion on why it is simple, so that he could further explain his point. |
Maybe you could improve your example in some ways; Use @asmico_attach_bot as an example, try to expand the functionality to show some basic yet useful things in webapp |
Sure, I will add some features. My intention was to show how to implement a webapp using pytelegrambotapi, rather than to showcase the functionality of webapp it self. |
Well, anyone can implement a mini app using code, and simply changing link to google.com |
@coder2020official what about now? |
Thanks, that is a really good example.
|
As I am going add async support is it fine to use this structure? (rather than duplicating web file twice) examples/ |
yep sounds good to me, no need for duplicating |
LGTM. @Badiboy ? |
👍 |
Description
Simple webapp example